PLANET-7714 Fix Sentry errors #2490
Open
+12
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
planet-4
added a commit
to greenpeace/planet4-test-proteus
that referenced
this pull request
Dec 31, 2024
/unhold 4343ccaf-2729-45a7-be4d-46e370db320d
Test instance is ready 🚀🌑 proteus | admin | blocks report | CircleCI | composer-local.json ⌚ 2025.01.01 05:26:04 |
planet-4
added a commit
to greenpeace/planet4-test-proteus
that referenced
this pull request
Jan 1, 2025
/unhold 9da77d7e-741e-401d-aec4-f6632ebcba94
planet-4
added a commit
to greenpeace/planet4-test-proteus
that referenced
this pull request
Jan 1, 2025
/unhold 760a45ae-f36c-410d-b215-f8f8689227bf
sagarsdeshmukh
force-pushed
the
PLANET-7714-Sentry-errors
branch
from
4dbe0d2 to
4d35adf
Compare
sagarsdeshmukh
requested review from
a team,
mardelnet,
GP-Dan-Tovbein and
Osong-Michael
and removed request for
a team
sagarsdeshmukh
changed the title
planet-4
added a commit
to greenpeace/planet4-test-proteus
that referenced
this pull request
Jan 1, 2025
/unhold 6059dba8-77c9-4deb-ae53-fd34e3a20cd6
mardelnet
reviewed
Jan 7, 2025
There was a problem hiding this comment.
Do we want to modify a migration script that was already run?
|
|
||
| if ($redirect_id) { | ||
| if ($redirect_page) { |
Comment on lines
+417
to
+419
| return $item !== null | ||
| && $nav_menu_item !== null | ||
| && $item->menu_item_parent === $nav_menu_item->menu_item_parent; |
There was a problem hiding this comment.
Can we make it simpler?
Suggested change
| return $item !== null | |
| && $nav_menu_item !== null | |
| && $item->menu_item_parent === $nav_menu_item->menu_item_parent; | |
| return $item && $nav_menu_item && $item->menu_item_parent === $nav_menu_item->menu_item_parent; |
| @@ -435,7 +437,7 @@ function render_navigation_block(array $attributes): string | |||
| // For child pages, only show link to the parent | |||
| if ($submenu_page->menu_item_parent !== 0) { | |||
| $parent_item = array_filter($menu_items, function ($item) use ($submenu_page) { | |||
| return (int) $item->ID === (int) $submenu_page->menu_item_parent; | |||
| return $submenu_page !== null && (int) $item->ID === (int) $submenu_page->menu_item_parent; | |||
There was a problem hiding this comment.
Same here:
Suggested change
| return $submenu_page !== null && (int) $item->ID === (int) $submenu_page->menu_item_parent; | |
| return $item && $submenu_page && (int) $item->ID === (int) $submenu_page->menu_item_parent; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref. https://jira.greenpeace.org/browse/PLANET-7714
Summary
Fix below type errors
Sentry error
Sentry Error